Skip to content

remove manifest link as it is not used and throws errors #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2019
Merged

remove manifest link as it is not used and throws errors #278

merged 1 commit into from
Nov 6, 2019

Conversation

jonasjabari
Copy link
Member

@jonasjabari jonasjabari commented Nov 6, 2019 •
edited
Loading

Issue #277: Missing manifest file

Changes

  • removed manifest link

Notes

  • the manifest file was linked when the dummy app was set up to use webpacker
  • webpacker is not used currently in the dummy app
  • manifest file link can be removed

pascalwengerter
pascalwengerter approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pascalwengerter pascalwengerter merged commit 231d04b into develop Nov 6, 2019
@pascalwengerter pascalwengerter deleted the fixing_issue_277 branch November 6, 2019 11:37
@pascalwengerter pascalwengerter mentioned this pull request Nov 6, 2019
Closed
@jonasjabari jonasjabari added this to the 0.7.3 milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jonasjabari @pascalwengerter