Skip to content

Issue 255 #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 8, 2019
Merged

Issue 255 #284

merged 12 commits into from
Nov 8, 2019

Conversation

pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter commented Nov 6, 2019 •
edited by jonasjabari
Loading

Issue #255: Move ActionView dependencies to separate component

Changes

  • Removed all ActionView dependencies form matestack/ui/core/app and matestack/ui/core/component
  • Created new actionview core component that includes the ActionView dependencies
  • Added an alias for the new actionview component to fit naming conventions
  • Wrote tests for new actionview component, static & dynamic
  • Wrote docs for new actionview component, static & dynamic

@pascalwengerter
Copy link
Contributor Author

Ready for review @jonasjabari 🎸

jonasjabari
jonasjabari requested changes Nov 8, 2019
View reviewed changes
Copy link
Member

@jonasjabari jonasjabari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jonasjabari jonasjabari merged commit fd2dfa0 into develop Nov 8, 2019
@pascalwengerter pascalwengerter mentioned this pull request Nov 8, 2019
Closed
@pascalwengerter pascalwengerter deleted the issue-255 branch November 13, 2019 08:00
@jonasjabari jonasjabari added this to the 0.7.3 milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasjabari jonasjabari jonasjabari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.3
Development

Successfully merging this pull request may close these issues.
2 participants
@pascalwengerter @jonasjabari