Skip to content

enable usage of async rerender_on on component-level #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2019
Merged

enable usage of async rerender_on on component-level #286

merged 1 commit into from
Nov 7, 2019

Conversation

jonasjabari
Copy link
Member

Issue #75: async rerender on component-level

Changes

  • fixed component_keys from components used in component-level
  • added deep component lookup on page
  • added deep component lookup on component (recursive, unlimited nesting)
  • added tests for async rerender_on usage on component-level
  • removed limitation note on docs and error message

pascalwengerter
pascalwengerter approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the most beautiful code written ever, but if the CI is happy so am I 😉 for now, good to merge!

spec/usage/components/async_spec.rb
other_dynamic_content_before = page.find("#other-dynamic-content-on-component").text

page.execute_script('MatestackUiCore.matestackEventHub.$emit("my_event")')
# sleep
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queee?

@pascalwengerter pascalwengerter merged commit f3cbba9 into develop Nov 7, 2019
@pascalwengerter pascalwengerter mentioned this pull request Nov 7, 2019
Closed
@pascalwengerter pascalwengerter deleted the implementing_issue_75 branch November 7, 2019 21:58
@jonasjabari jonasjabari added this to the 0.7.3 milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jonasjabari @pascalwengerter