Skip to content

fixed form component usage on component-level #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2019
Merged

fixed form component usage on component-level #287

merged 1 commit into from
Nov 8, 2019

Conversation

jonasjabari
Copy link
Member

Issue #256: Form Component on Component Level

Changes

  • fixed component node builder in order to properly include included_config
  • resolves bug described in issue referenced above
  • added tests for forms used on component-level

@jonasjabari jonasjabari changed the title fixed included config on component level fixed form component usage on component-level Nov 7, 2019
pascalwengerter
pascalwengerter approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change seems marginal, wasn't this working before?

Good to have (passing) tests though and it seems to be working, so good to merge!

@jonasjabari
Copy link
Member Author

Nope, it wasn't working. That's why I created the issue :P
A critical instance variable @included_config was overwritten before. Moving the variable assignment a bit down prevented the variable from being overwritten.

@jonasjabari jonasjabari merged commit 1a396d3 into develop Nov 8, 2019
@pascalwengerter pascalwengerter deleted the fixing_issue_256 branch November 13, 2019 08:00
@jonasjabari jonasjabari added this to the 0.7.3 milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jonasjabari @pascalwengerter