matestack · jonasjabari · Nov 10, 2019 · Sep 26, 2019 · Sep 29, 2019 · Sep 29, 2019
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,65 @@
 # Changelog
 
+## v0.7.3
+
+[Merged PRs](https://github.com/basemate/matestack-ui-core/pulls?q=is%3Apr+is%3Aclosed+milestone%3A0.7.3)
+
+[Solved Issues](https://github.com/basemate/matestack-ui-core/issues?q=is%3Aissue+is%3Aclosed+milestone%3A0.7.3)
+
+### Potential Breaking Change - Migration Note
+
+Until `0.7.2.1`, we included all `ActionView` modules in `Matestack::Ui::StaticComponent` and `Matestack::Ui::DynamicComponent`. As we didn't use these modules in all of our core components, we decided to move the `ActionView` modules to the new `Matestack::Ui::StaticActionviewComponent` and `Matestack::Ui::DynamicActionviewComponent` class. If you use `ActionView` modules in your components, you have to change the class you inherit from. This might be a potential breaking change for some users - we are not bumping to 0.8.0 as we don't break explicit specified behavior. If you have any problems, reach out via gitter!
+
+### Security Fixes
+
+none
+
+### Improvements
+
+* Move ActionView dependencies to separate, custom-core-component by pascalwengerter
+* Add documentation for testing on macOS by marcoroth
+* Add HTML <ruby> tag to core components by stiwwelll
+* Add HTML <rt> tag to core components by stiwwelll
+* Add HTML <rp> tag to core components by stiwwelll
+* Add HTML <q> tag to core components by GrantBarry
+* Add HTML <pre> tag to core components by tae8838
+* Add HTML <param> tag to core components by marcoroth
+* Add HTML <output> tag to core components by marcoroth
+* Add HTML <object> tag to core components by pascalwengerter
+* Add HTML <noscript> tag to core components by stiwwelll
+* Add HTML <meter> tag to core components by bdlb77
+* Add HTML <mark> tag to core components by marcoroth
+* Add HTML <map> tag to core components by pascalwengerter
+* Add HTML <legend> tag to core components by stiwwelll
+* Add HTML <kbd> tag to core components by marcoroth
+* Add HTML <ins> tag to core components by lumisce
+* Add HTML <figure> tag to core components by lumisce
+* Add HTML <em> tag to core components by citizen428
+* Add HTML <dt> tag to core components by mayanktap
+* Add HTML <dl> tag to core components by mayanktap
+* Add HTML <dd> tag to core components by mayanktap
+* Add HTML <code> tag to core components by pascalwengerter
+* Add HTML <cite> tag to core components by cameronnorman
+* Add HTML <var> tag to core components by pascalwengerter
+* Add HTML <s> tag to core components by Manukam
+* Add HTML bold tag to core components by GrantBarry
+* Add HTML area tag to core components by pascalwengerter
+* Add tests for video component by MarcoBomfim
+* Usage of RecordTagHelper by pascalwengerter
+* Add HTML aside tag to core components by borref
+* Add HTML address tag to core components by michaelrevans
+* Add HTML sup tag to core components by borref
+* Add params options to link component documentation by pascalwengerter
+
+### Bugfixes
+
+* Unexpected behaviour when creating a record in progress by jonasjabari
+* couldn't find file 'matestack_ui_core_manifest.js' on dummy app by jonasjabari
+* Add For Attribute to Stand Alone Label Component by bdlb77
+* Form component doesn't work on component-level by jonasjabari
+* Async component doesn't work on component-level by jonasjabari
+
+
 ## v0.7.2.1
 
 [Merged PRs](https://github.com/basemate/matestack-ui-core/milestone/5?closed=1)

diff --git a/Gemfile b/Gemfile
@@ -13,6 +13,7 @@ gemspec
 
 # To use a debugger
 # gem 'byebug', group: [:development, :test]
+# gem 'pry-byebug', group: [:development, :test]
 
 gem "trailblazer"
 gem "trailblazer-rails"
@@ -31,6 +32,7 @@ group :development, :test do
   gem 'simplecov', require: false, group: :test
   gem 'byebug'
   gem 'webmock'
+  gem 'webdrivers', '~> 4.1'
 end
 
 group :test do

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    matestack-ui-core (0.7.1)
+    matestack-ui-core (0.7.2.1)
       cells-haml
       cells-rails
       haml
@@ -123,7 +123,7 @@ GEM
     mini_mime (1.0.1)
     mini_portile2 (2.4.0)
     minitest (5.11.3)
-    nio4r (2.4.0)
+    nio4r (2.5.2)
     nokogiri (1.10.4)
       mini_portile2 (~> 2.4.0)
     pipetree (0.1.1)
@@ -231,6 +231,10 @@ GEM
     tzinfo (1.2.5)
       thread_safe (~> 0.1)
     uber (0.1.0)
+    webdrivers (4.1.2)
+      nokogiri (~> 1.6)
+      rubyzip (~> 1.0)
+      selenium-webdriver (>= 3.0, < 4.0)
     webmock (3.5.1)
       addressable (>= 2.3.6)
       crack (>= 0.3.2)
@@ -264,6 +268,7 @@ DEPENDENCIES
   trailblazer
   trailblazer-cells
   trailblazer-rails
+  webdrivers (~> 4.1)
   webmock
   webpacker (~> 3.5)
 

diff --git a/app/concepts/matestack/ui/core/actionview/dynamic.haml b/app/concepts/matestack/ui/core/actionview/dynamic.haml
@@ -0,0 +1,6 @@
+%component{dynamic_tag_attributes}
+  %div
+    %div{"v-if": "asyncTemplate == null"}
+      = render_content
+    %div{"v-if": "asyncTemplate != null"}
+      %v-runtime-template{":template":"asyncTemplate"}
diff --git a/app/concepts/matestack/ui/core/actionview/dynamic.rb b/app/concepts/matestack/ui/core/actionview/dynamic.rb
@@ -0,0 +1,28 @@
+module Matestack::Ui::Core::Actionview
+  class Dynamic < Matestack::Ui::Core::Component::Dynamic
+
+    include ActionView::Helpers::ActiveModelHelper
+    include ActionView::Helpers::ActiveModelInstanceTag
+    include ActionView::Helpers::AssetTagHelper
+    include ActionView::Helpers::AssetUrlHelper
+    include ActionView::Helpers::AtomFeedHelper
+    include ActionView::Helpers::CacheHelper
+    include ActionView::Helpers::CaptureHelper
+    include ActionView::Helpers::CspHelper
+    include ActionView::Helpers::CsrfHelper
+    include ActionView::Helpers::DateHelper
+    include ActionView::Helpers::DebugHelper
+    include ActionView::Helpers::FormHelper
+    include ActionView::Helpers::FormOptionsHelper
+    include ActionView::Helpers::FormTagHelper
+    include ActionView::Helpers::JavaScriptHelper
+    include ActionView::Helpers::NumberHelper
+    include ActionView::Helpers::OutputSafetyHelper
+    include ActionView::Helpers::SanitizeHelper
+    include ActionView::Helpers::TagHelper
+    include ActionView::Helpers::TextHelper
+    include ActionView::Helpers::TranslationHelper
+    include ActionView::Helpers::UrlHelper
+
+  end
+end
diff --git a/app/concepts/matestack/ui/core/actionview/static.haml b/app/concepts/matestack/ui/core/actionview/static.haml
@@ -0,0 +1 @@
+= render_content
diff --git a/app/concepts/matestack/ui/core/actionview/static.rb b/app/concepts/matestack/ui/core/actionview/static.rb
@@ -0,0 +1,28 @@
+module Matestack::Ui::Core::Actionview
+  class Static < Matestack::Ui::Core::Component::Static
+
+    include ActionView::Helpers::ActiveModelHelper
+    include ActionView::Helpers::ActiveModelInstanceTag
+    include ActionView::Helpers::AssetTagHelper
+    include ActionView::Helpers::AssetUrlHelper
+    include ActionView::Helpers::AtomFeedHelper
+    include ActionView::Helpers::CacheHelper
+    include ActionView::Helpers::CaptureHelper
+    include ActionView::Helpers::CspHelper
+    include ActionView::Helpers::CsrfHelper
+    include ActionView::Helpers::DateHelper
+    include ActionView::Helpers::DebugHelper
+    include ActionView::Helpers::FormHelper
+    include ActionView::Helpers::FormOptionsHelper
+    include ActionView::Helpers::FormTagHelper
+    include ActionView::Helpers::JavaScriptHelper
+    include ActionView::Helpers::NumberHelper
+    include ActionView::Helpers::OutputSafetyHelper
+    include ActionView::Helpers::SanitizeHelper
+    include ActionView::Helpers::TagHelper
+    include ActionView::Helpers::TextHelper
+    include ActionView::Helpers::TranslationHelper
+    include ActionView::Helpers::UrlHelper
+
+  end
+end
diff --git a/app/concepts/matestack/ui/core/app/app.rb b/app/concepts/matestack/ui/core/app/app.rb
@@ -1,33 +1,9 @@
 module Matestack::Ui::Core::App
   class App < Trailblazer::Cell
-    include ActionView::Helpers::ActiveModelHelper
-    include ActionView::Helpers::ActiveModelInstanceTag
-    include ActionView::Helpers::AssetTagHelper
-    include ActionView::Helpers::AssetUrlHelper
-    include ActionView::Helpers::AtomFeedHelper
-    include ActionView::Helpers::CacheHelper
-    include ActionView::Helpers::CaptureHelper
-    include ActionView::Helpers::CspHelper
-    include ActionView::Helpers::CsrfHelper
-    include ActionView::Helpers::DateHelper
-    include ActionView::Helpers::DebugHelper
-    include ActionView::Helpers::FormHelper
-    include ActionView::Helpers::FormOptionsHelper
-    include ActionView::Helpers::FormTagHelper
-    include ActionView::Helpers::JavaScriptHelper
-    include ActionView::Helpers::NumberHelper
-    include ActionView::Helpers::OutputSafetyHelper
-    include ActionView::Helpers::RecordTagHelper
-    # include ActionView::Helpers::RenderingHelper
-    include ActionView::Helpers::SanitizeHelper
-    include ActionView::Helpers::TagHelper
-    include ActionView::Helpers::TextHelper
-    include ActionView::Helpers::TranslationHelper
-    include ActionView::Helpers::UrlHelper
+
     include ::Cell::Haml
     include Matestack::Ui::Core::ApplicationHelper
     include Matestack::Ui::Core::ToCell
-    # include ::Rails.application.routes.url_helpers
 
     view_paths << "#{Matestack::Ui::Core::Engine.root}/app/concepts"
 

diff --git a/app/concepts/matestack/ui/core/area/area.haml b/app/concepts/matestack/ui/core/area/area.haml
@@ -0,0 +1 @@
+%area{@tag_attributes}
diff --git a/app/concepts/matestack/ui/core/area/area.rb b/app/concepts/matestack/ui/core/area/area.rb
@@ -0,0 +1,18 @@
+module Matestack::Ui::Core::Area
+  class Area < Matestack::Ui::Core::Component::Static
+    def setup
+      @tag_attributes.merge!({
+        alt: options[:alt],
+        coords: options[:coords].join(','),
+        download: options[:download],
+        href: options[:href],
+        hreflang: options[:hreflang],
+        media: options[:media],
+        rel: options[:rel],
+        shape: options[:shape],
+        target: options[:target],
+        type: options[:type]
+      })
+    end
+  end
+end
diff --git a/app/concepts/matestack/ui/core/aside/aside.haml b/app/concepts/matestack/ui/core/aside/aside.haml
@@ -0,0 +1,3 @@
+%aside{@tag_attributes}
+  - if block_given?
+    = yield
diff --git a/app/concepts/matestack/ui/core/aside/aside.rb b/app/concepts/matestack/ui/core/aside/aside.rb
@@ -0,0 +1,5 @@
+module Matestack::Ui::Core::Aside
+  class Aside < Matestack::Ui::Core::Component::Static
+
+  end
+end
diff --git a/app/concepts/matestack/ui/core/b/b.haml b/app/concepts/matestack/ui/core/b/b.haml
@@ -0,0 +1,5 @@
+%b{@tag_attributes}
+  - if options[:text].nil? && block_given?
+    = yield
+  - else
+    = options[:text]
diff --git a/app/concepts/matestack/ui/core/b/b.rb b/app/concepts/matestack/ui/core/b/b.rb
@@ -0,0 +1,5 @@
+module Matestack::Ui::Core::B
+  class B < Matestack::Ui::Core::Component::Static
+
+  end
+end
diff --git a/app/concepts/matestack/ui/core/cite/cite.haml b/app/concepts/matestack/ui/core/cite/cite.haml
@@ -0,0 +1,5 @@
+%cite{@tag_attributes}
+  - if options[:text].nil? && block_given?
+    = yield
+  - else
+    = options[:text]
diff --git a/app/concepts/matestack/ui/core/cite/cite.rb b/app/concepts/matestack/ui/core/cite/cite.rb
@@ -0,0 +1,5 @@
+module Matestack::Ui::Core::Cite
+  class Cite < Matestack::Ui::Core::Component::Static
+
+  end
+end
diff --git a/app/concepts/matestack/ui/core/code/code.haml b/app/concepts/matestack/ui/core/code/code.haml
@@ -0,0 +1,5 @@
+%code{@tag_attributes}
+  - if options[:text].nil? && block_given?
+    = yield
+  - else
+    = options[:text]
diff --git a/app/concepts/matestack/ui/core/code/code.rb b/app/concepts/matestack/ui/core/code/code.rb
@@ -0,0 +1,5 @@
+module Matestack::Ui::Core::Code
+  class Code < Matestack::Ui::Core::Component::Static
+
+  end
+end
diff --git a/app/concepts/matestack/ui/core/component/dynamic.rb b/app/concepts/matestack/ui/core/component/dynamic.rb
@@ -1,30 +1,6 @@
 module Matestack::Ui::Core::Component
   class Dynamic < Trailblazer::Cell
 
-    include ActionView::Helpers::ActiveModelHelper
-    include ActionView::Helpers::ActiveModelInstanceTag
-    include ActionView::Helpers::AssetTagHelper
-    include ActionView::Helpers::AssetUrlHelper
-    include ActionView::Helpers::AtomFeedHelper
-    include ActionView::Helpers::CacheHelper
-    include ActionView::Helpers::CaptureHelper
-    include ActionView::Helpers::CspHelper
-    include ActionView::Helpers::CsrfHelper
-    include ActionView::Helpers::DateHelper
-    include ActionView::Helpers::DebugHelper
-    include ActionView::Helpers::FormHelper
-    include ActionView::Helpers::FormOptionsHelper
-    include ActionView::Helpers::FormTagHelper
-    include ActionView::Helpers::JavaScriptHelper
-    include ActionView::Helpers::NumberHelper
-    include ActionView::Helpers::OutputSafetyHelper
-    include ActionView::Helpers::RecordTagHelper
-    # include ActionView::Helpers::RenderingHelper
-    include ActionView::Helpers::SanitizeHelper
-    include ActionView::Helpers::TagHelper
-    include ActionView::Helpers::TextHelper
-    include ActionView::Helpers::TranslationHelper
-    include ActionView::Helpers::UrlHelper
     include ::Cell::Haml
     include Matestack::Ui::Core::ApplicationHelper
     include Matestack::Ui::Core::ToCell
@@ -158,7 +134,7 @@ def components(&block)
       @nodes = Matestack::Ui::Core::ComponentNode.build(self, nil, &block)
 
       @nodes.each do |key, node|
-        @cells[key] = to_cell(key, node["component_name"], node["config"], node["argument"], node["components"], node["included_config"], node["cached_params"])
+        @cells[key] = to_cell("#{@component_key}__#{key}", node["component_name"], node["config"], node["argument"], node["components"], node["included_config"], node["cached_params"])
       end
     end
 
@@ -191,6 +167,38 @@ def modifiers
       result.join(" ")
     end
 
+    def render_child_component component_key, current_search_keys_array
+      if respond_to? :prepare
+        prepare
+      end
+
+      response
+
+      if current_search_keys_array.count > 1
+        if @nodes.dig(*current_search_keys_array) == nil
+          rest = []
+          while @nodes.dig(*current_search_keys_array) == nil
+            rest << current_search_keys_array.pop
+          end
+          node = @nodes.dig(*current_search_keys_array)
+          cell = to_cell(component_key, node["component_name"], node["config"], node["argument"], node["components"], node["included_config"], node["cached_params"])
+          begin
+            return cell.render_child_component component_key, rest.reverse[1..-1]
+          rescue
+            return cell.render_content
+          end
+        else
+          node = @nodes.dig(*current_search_keys_array)
+          cell = to_cell(component_key, node["component_name"], node["config"], node["argument"], node["components"], node["included_config"], node["cached_params"])
+          return cell.render_content
+        end
+      else
+        node = @nodes[current_search_keys_array[0]]
+        cell = to_cell(component_key, node["component_name"], node["config"], node["argument"], node["components"], node["included_config"], node["cached_params"])
+        return cell.render_content
+      end
+    end
+
     private
 
       def generate_children_cells

diff --git a/app/concepts/matestack/ui/core/dd/dd.haml b/app/concepts/matestack/ui/core/dd/dd.haml
@@ -0,0 +1,5 @@
+%dd{@tag_attributes}
+  - if options[:text].nil? && block_given?
+    = yield
+  - else
+    = options[:text]
diff --git a/app/concepts/matestack/ui/core/dd/dd.rb b/app/concepts/matestack/ui/core/dd/dd.rb
@@ -0,0 +1,5 @@
+module Matestack::Ui::Core::Dd
+  class Dd < Matestack::Ui::Core::Component::Static
+
+  end
+end
diff --git a/app/concepts/matestack/ui/core/dl/dl.haml b/app/concepts/matestack/ui/core/dl/dl.haml
@@ -0,0 +1,5 @@
+%dl{@tag_attributes}
+  - if options[:text].nil? && block_given?
+    = yield
+  - else
+    = options[:text]
diff --git a/app/concepts/matestack/ui/core/dl/dl.rb b/app/concepts/matestack/ui/core/dl/dl.rb
@@ -0,0 +1,5 @@
+module Matestack::Ui::Core::Dl
+  class Dl < Matestack::Ui::Core::Component::Static
+
+  end
+end
diff --git a/app/concepts/matestack/ui/core/dt/dt.haml b/app/concepts/matestack/ui/core/dt/dt.haml
@@ -0,0 +1,5 @@
+%dt{@tag_attributes}
+  - if options[:text].nil? && block_given?
+    = yield
+  - else
+    = options[:text]