Skip to content

Add bdi core component & docs & tests #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2019
Merged

Add bdi core component & docs & tests #300

merged 1 commit into from
Nov 15, 2019

Conversation

pascalwengerter
Copy link
Contributor

Issue #173: Add bdi component

Changes

  • Add <bdi> component including docs & test

marcoroth
marcoroth approved these changes Nov 15, 2019
View reviewed changes
Copy link
Collaborator

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

borref
borref approved these changes Nov 15, 2019
View reviewed changes
Copy link
Collaborator

@borref borref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well

@pascalwengerter
Copy link
Contributor Author

Thanks for the review @borref @marcoroth

@pascalwengerter pascalwengerter merged commit a0d22b0 into develop Nov 15, 2019
@pascalwengerter pascalwengerter deleted the add_bdi_component branch November 15, 2019 10:35
@pascalwengerter pascalwengerter mentioned this pull request Nov 20, 2019
Closed
@jonasjabari jonasjabari added this to the 0.7.4 milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoroth marcoroth marcoroth approved these changes

@borref borref borref approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.4
Development

Successfully merging this pull request may close these issues.
4 participants
@pascalwengerter @marcoroth @borref @jonasjabari