Skip to content

Add bdo core component including tests & docs #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 20, 2019
Merged

Add bdo core component including tests & docs #301

merged 3 commits into from
Nov 20, 2019

Conversation

pascalwengerter
Copy link
Contributor

Issue #174: Add bdo component

Changes

  • Added <bdo> component & tests & docs

marcoroth
marcoroth reviewed Nov 15, 2019
View reviewed changes
bdlb77
bdlb77 requested changes Nov 18, 2019
View reviewed changes
Copy link
Collaborator

@bdlb77 bdlb77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned before, it'll be good to add the extra edge case to the Test in case someone doesn't add a dir. Otherwise it looks good!

@pascalwengerter
Copy link
Contributor Author

Here ya go, mates!

@pascalwengerter
Copy link
Contributor Author

@bdlb77 merging this since your request was the same as Marco's! ⛵

@pascalwengerter pascalwengerter removed the request for review from bdlb77 November 20, 2019 16:58
@pascalwengerter pascalwengerter merged commit feb02c6 into develop Nov 20, 2019
@pascalwengerter pascalwengerter deleted the add_bdo_component branch November 20, 2019 16:59
@pascalwengerter pascalwengerter mentioned this pull request Nov 20, 2019
Closed
@jonasjabari jonasjabari added this to the 0.7.4 milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdlb77 bdlb77 bdlb77 requested changes

@marcoroth marcoroth marcoroth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.4
Development

Successfully merging this pull request may close these issues.
4 participants
@pascalwengerter @marcoroth @bdlb77 @jonasjabari