Skip to content

Refer to p for what it is (a Kernel method not a keyword) #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2019

Conversation

PragTob
Copy link
Collaborator

@PragTob PragTob commented Dec 11, 2019

For the sake of correctness :)

Side discussion: This also means that it is possible to
override the p function and have it function as a paragraph
function.

Whether or not to do it is a discussion that should probably
be had in a different issue.

It's the question if taking away the beloved p from debugging
inside their component (making it available as _p or what not)
is a reasonable exchange for having a more direct mapping to the
HTML <p> tag and that people don't have to keep that one
exception mind.

For the sake of correctness :)

Side discussion: This also means that it _is_ possible to
override the p function and have it function as a paragraph
function.

Whether or not to do it is a discussion that should probably
be had in a different issue.

It's the question if taking away the beloved p from debugging
inside their component (making it available as `_p` or what not)
is a reasonable exchange for having a more direct mapping to the
HTML `<p>` tag and that people don't have to keep that one
exception mind.
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@pascalwengerter pascalwengerter merged commit 8a34a1f into matestack:develop Dec 16, 2019
@PragTob PragTob deleted the fix-p-note branch December 16, 2019 12:27
@jonasjabari jonasjabari added this to the 0.7.4 milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants