Skip to content

Add dialog component, add missing line in core component generator #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 1, 2020
Merged

Add dialog component, add missing line in core component generator #318

merged 2 commits into from
Jan 1, 2020

Conversation

pascalwengerter
Copy link
Contributor

Issue #185: Add dialog component

Changes

  • Added tested & documented dialog component
  • Added closing line to HTML snippet in core component generator

@pascalwengerter
Copy link
Contributor Author

@marcoroth @michaelrevans happy new year & thanks for the review, m8s!

@pascalwengerter pascalwengerter merged commit 89e7d75 into develop Jan 1, 2020
@pascalwengerter pascalwengerter deleted the add_dialog_component branch January 1, 2020 16:12
@jonasjabari jonasjabari added this to the 0.7.4 milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoroth marcoroth marcoroth approved these changes

@michaelrevans michaelrevans michaelrevans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.4
Development

Successfully merging this pull request may close these issues.
4 participants
@pascalwengerter @marcoroth @michaelrevans @jonasjabari