Skip to content

Change spelling of behaviour to behavior #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/issue_template.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
<!-- This is a template only, remove/add sections below as appropriate (e.g. for a new feature, there might be no 'current behaviour'.) -->
<!-- This is a template only, remove/add sections below as appropriate (e.g. for a new feature, there might be no 'current behavior'.) -->

<!-- First indicate whether you want to request an ENHANCEMENT or report a BUG by using the correct Github label in the side panel* -->

**What is the current behaviour?**
**What is the current behavior?**

<!-- add current behaviour here -->
<!-- add current behavior here -->

**If the current behaviour is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug might get fixed faster if we can run your code and it doesn't have extra dependencies. Add a link to a sample repo and/or any relevant code below:**
**If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug might get fixed faster if we can run your code and it doesn't have extra dependencies. Add a link to a sample repo and/or any relevant code below:**

<!-- add additional links/info here -->

**What is the expected behaviour?**
**What is the expected behavior?**

<!-- add expected behaviour here -->
<!-- add expected behavior here -->

**Which versions of Matestack, and which browser/OS are affected by this issue? Did this work in previous versions of Matestack?**

Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ none

### Bugfixes

* Unexpected behaviour when creating a record in progress by jonasjabari
* Unexpected behavior when creating a record in progress by jonasjabari
* couldn't find file 'matestack_ui_core_manifest.js' on dummy app by jonasjabari
* Add For Attribute to Stand Alone Label Component by bdlb77
* Form component doesn't work on component-level by jonasjabari
Expand Down
2 changes: 1 addition & 1 deletion docs/architecture/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ The Cells get wrapped by a `component` tag. `dynamic_tag_attributes` returns a h
- `"ref": component_id` may be used to identify the specific instance of this Component on one Page
- `:params": @url_params.to_json` is used to pass request params to the Vue.js Component instance
- `":component-config": @component_config.to_json` is used to pass configuration to the Vue.js Component instance
- this is very useful if a Vue.js component relies on meta data to perfom its desired behaviour during runtime
- this is very useful if a Vue.js component relies on meta data to perfom its desired behavior during runtime
- example: the dynamic core Component `transition` gets a `path` config when used in a `response` method. As the value is just a symbol referencing a rails route, the Component needs to translate the symbol to a string on the server-side. This string is then added to the `@component_config` and parsed by the `transition` Vue.js component instance during browser runtime
- `"inline-template": true` needs to be set in order to tell Vue.js that this component uses the server-side rendered markup as template.

Expand Down
2 changes: 1 addition & 1 deletion docs/concepts/component.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ This document aims to give a brief introducing to the different kinds of compone

## Core Components

See [here](/docs/components/README.md) for a list of available `core components`. In general, they are separated into HTML-only **static** components and **dynamic** components that come with Javascript-powered, dynamic behaviour.
See [here](/docs/components/README.md) for a list of available `core components`. In general, they are separated into HTML-only **static** components and **dynamic** components that come with Javascript-powered, dynamic behavior.

If you miss a component that you think we're missing in the `core components` right now, [create an issue](https://github.com/basemate/matestack-ui-core/issues/new) in our GitHub!

Expand Down
4 changes: 2 additions & 2 deletions spec/rails_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,11 @@
# instead of true.
config.use_transactional_fixtures = true

# RSpec Rails can automatically mix in different behaviours to your tests
# RSpec Rails can automatically mix in different behaviors to your tests
# based on their file location, for example enabling you to call `get` and
# `post` in specs under `spec/controllers`.
#
# You can disable this behaviour by removing the line below, and instead
# You can disable this behavior by removing the line below, and instead
# explicitly tag your specs with their type, e.g.:
#
# RSpec.describe UsersController, :type => :controller do
Expand Down
4 changes: 2 additions & 2 deletions spec/usage/base/component_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -297,9 +297,9 @@ def response

end

it "components can use async component to wrap static components and add basic dynamic behaviour" #not working right now
it "components can use async component to wrap static components and add basic dynamic behavior" #not working right now

it "pages can use async component to wrap static components and add basic dynamic behaviour" do
it "pages can use async component to wrap static components and add basic dynamic behavior" do

module Matestack::Ui::Core::SomeStaticComponent
class SomeStaticComponent < Matestack::Ui::StaticComponent
Expand Down