Fix Note for running tests on Mac #324
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No idea why before it didn't work, basically rewrote it and now the parser realizes its mistake - maybe an odd character? 
marcoroth
approved these changes
Jan 27, 2020
PragTob
added a commit
that referenced
this pull request
Jan 27, 2020
Noticed that a few of these weren't noted, but got them together from the CircleCI workflow. Also moved the test section up as I think the most important thing after setting up to see that it works is running the tests. Kinda deprecates/clashes with #324 as I changed where that note is displayed and how it's incorporated so that it's no longer needed.
2 tasks
|
Please note that #334 basically clashes with these changes and so might be merged in favor of this one. |
|
closing in favor of #334 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No idea why before it didn't work, basically rewrote it and now the parser realizes its mistake - maybe an odd character/whitespace?