Adjust the order in which components are provided #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before it was rather confusing for me as other component doesn't use some component and later also isn't used in the page so it was rather difficult to find out how both components end up in the page. I hope that by reversing the order of the components so that first people are introduced to other_component, which is then used in some component which is then used in the page this is made more understandable. Also added another note mentioning this.
jonasjabari
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before it was rather confusing for me as other component doesn't
use some component and later also isn't used in the page so it
was rather difficult to find out how both components end up
in the page.
I hope that by reversing the order of the components so that first
people are introduced to other_component, which is then used in
some component which is then used in the page this is made more
understandable.
Also added another note mentioning this.