Fix Anchor Link triggers transition #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PragTob
commented
Feb 5, 2020
| @@ -1,7 +1,7 @@ | |||
| import Vue from 'vue/dist/vue.esm' | |||
| import axios from 'axios' | |||
There was a problem hiding this comment.
wasn't used anywhere, in the file so I removed it. I hope I'm not unaware of some side effect this had, but the tests pass 🤷♂️
PragTob
commented
Feb 5, 2020
|
|
||
| # Hacky/instable but easy way to set my custom App for this page | ||
| def set_app_class | ||
| @app_class = Apps::MyTestApp |
There was a problem hiding this comment.
as the comment states, this is hacky but considering doing naming convetions, a new controller and appending to the routes etc. this seemed preferable to me.
jonasjabari
approved these changes
Feb 5, 2020
This was referenced Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4: Anchor Link Click triggers full page transition
Changes
Notes