Skip to content

Dockerized core dev #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Feb 10, 2020
Merged

Dockerized core dev #368

merged 39 commits into from
Feb 10, 2020

Conversation

jonasjabari
Copy link
Member

Issue #295: Dockerized core dev and test environment

Changes

  • added Docker Images for development and test
  • added rspec retry gem in oder to prevent flaky tests
  • fixed order of spec expectations causing flaky tests
  • added docs for dockerized dev and test workflow
  • switched to github action for CI testing
  • the test suite now runs the exact same way locally as on CI

Notes

  • form this PR on, we will only support dockerized core development/testing in order to streamline collaboration
  • specs and configs are mainly configured in order to run in the dockerized workflows
  • information about this will be published with the upcoming release

@jonasjabari
saving latest state WIP
2e54af8
@jonasjabari
Merge branch 'develop' into dockerized_core_dev
ae4297a
@jonasjabari
updated Gems
f299c8c
@jonasjabari
added sandbox app and pages to dummy app
8b5a138
@jonasjabari
remove uncompleted guide from branch
937eb0f
@jonasjabari
added docs and compose configs in order to support docker-compose usa…
de862d8 
…ge with local user ID
@jonasjabari
added contribution docs for bundler and yarn
1e883d2
@jonasjabari
added new js builds
8457416
@jonasjabari
fixed dummy app
7ff2814
@jonasjabari
WIP saving status quo
467ea2f
@jonasjabari
Merge branch 'develop' into dockerized_core_dev
6ce1f1e
@jonasjabari
WIP: updated ruby, alpine and bundler version in docker dev and test …
fa1f6db 
…images. dummy app yarn install is failing due to node-sass build errors
@jonasjabari
Merge branch 'develop' into dockerized_core_dev
44cd31e
@jonasjabari
upgraded builder app to ruby 2.7.0
420ce0c
@jonasjabari
downgraded to ruby 2.6.5 and alpine3.9 due to headless chrome errors
dc8b6d2
@jonasjabari
added rspec-retry in order to resolve flaky specs
38941c0
@jonasjabari
added rspec-retry in order to resolve flaky specs
77a430b
@jonasjabari
fixed html expectations due to xhtml rendering within dockerized head…
6ef1821 
…less testing
@jonasjabari
fixed typo
9fd717f
@jonasjabari
just render runtime exceptions instead of throwing exceptions in test…
821b601 
… env exceptions break the dockerized test workflow
@jonasjabari
deactivated generator tests as they are failing and causing issues th…
65d3d05 
…rough copying folders while running the tests. Needs to be fixed with a different testing approach
@jonasjabari
moved renderer spec in order to streamline spec workflow. rethinking …
13c3520 
…spec folder structure is required though
@jonasjabari
first try to run dockerized test suite on circle ci
b553ff5
@jonasjabari
try to run dockerized test suite on circle ci
226a3f6
@jonasjabari
try to run dockerized test suite on circle ci
4a7cd0c
@jonasjabari
try to run dockerized test suite on circle ci
e41d6f9
@jonasjabari
try to run dockerized test suite on circle ci
761b620
@jonasjabari
try to run dockerized test suite on circle ci
6c626a7
@jonasjabari
try to run dockerized test suite on circle ci
64e1f30
@jonasjabari
try to run dockerized test suite on circle ci
2ffc738
@jonasjabari jonasjabari merged commit f42974e into develop Feb 10, 2020
@jonasjabari jonasjabari mentioned this pull request Feb 10, 2020
Closed
1 task
@jonasjabari jonasjabari added this to the 0.7.4 milestone Feb 10, 2020
@jonasjabari jonasjabari mentioned this pull request Feb 10, 2020
Closed
@pascalwengerter pascalwengerter deleted the dockerized_core_dev branch February 17, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.4
Development

Successfully merging this pull request may close these issues.
1 participant
@jonasjabari