Skip to content

update form_select radio buttons to have a unique name for different … #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 25, 2020

Conversation

NdotHenning
Copy link
Member

Please make sure to target feature and bugfix requests to develop branch

Issue #399: Short description here

Changes

  • Use a unique value for radio button name attribute
  • add/expand tests

Notes

  • Unique value for name attribute created from attr_key and value. Not only value like it was before.

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pascalwengerter
Copy link
Contributor

@NdotHenning tests seem to be failing since you probably copied the routes from the checkbox spec (?) could you fix that by giving them (both checkbox and radio routes maybe) unique names?

See CI error msg below:
You may have defined two routes with the same name using the :asoption, or you may be overriding a route already defined by a resource with the same naming. For the latter, you can restrict the routes created withresourcesas explained here:

@jonasjabari jonasjabari merged commit 2ec0b8d into develop Mar 25, 2020
@pascalwengerter pascalwengerter deleted the 20200311_henning_unique-names-for-radio-buttons branch April 4, 2020 11:11
@jonasjabari jonasjabari added this to the 0.7.6 milestone Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants