Skip to content

Async rerender for components misses view_context #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2020

Conversation

NdotHenning
Copy link
Member

@NdotHenning NdotHenning commented Apr 2, 2020

Please make sure to target feature and bugfix requests to develop branch

Async rerendering of components misses view context

Using a async component inside a page which accesses a controller helper like devises current_user, current_user will be nil, because the page can't access the helper.

Changes

  • Adding view context to render_component
  • Adding view context to app rendering
  • Adding specs for page, component and app view context access

Nils Henning and others added 3 commits April 2, 2020 11:09
…th-view-context

added specs for component access tp action view context and added acc…
@jonasjabari jonasjabari merged commit ec9441b into develop Apr 27, 2020
@jonasjabari jonasjabari added this to the 0.7.6 milestone Apr 28, 2020
@jonasjabari jonasjabari mentioned this pull request Apr 28, 2020
@NdotHenning NdotHenning deleted the nh/render-components-with-view-context branch August 24, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants