rename pg component to paragraph component #48
Conversation
|
Thank you! Before merging this, we need to make sure, that users get informed about this breaking change. Either we provide backwards compatibility (leaving the pg component as is - next to the new paragraph component - for the next releases and add a warning when being used) or communicate this breaking change explicitly. I would prefer a structured and documented approach including terminated backwards compatibility. What do you think? |
|
Great thinking from your side. I have re-added the pg core component including tests and the docs, now mentioning its deprecation and linking the "new" paragraph component. Maybe we should introduce a deprecation warning from the 0.7 relase on and remove it completely at the 0.8 release? |
|
|
||
| Show [specs](../../spec/usage/components/paragraph_spec.rb) | ||
|
|
||
| The HTML `<p>` tag implemented in ruby. This is a workaround because the single `p` is the short version of `puts` in ruby. |
There was a problem hiding this comment.
@PasWen actually p is a bit different from puts, it's not the short version. p calls .inspect on the printed object, puts not.
There was a problem hiding this comment.
Hey,
thanks for pointing it out, just fixed it in the documentation (and learned sth new on the way;)!
Fixes #47