Skip to content

Allow actions to accept id and class attributes #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

michaelrevans
Copy link
Collaborator

Fixes #44

Added

N/A

Changed

  • pass @tag_attributes along to action, allowing for id and class attributes to be defined
  • add spec for class and id in action
  • update action documentation to reflect the changes

Notes

  • The approach that I took now means that the class and id attributes have to be defined in what is commonly called action_config, although this config seems more aimed at the underlying action (the method, the path, success, failure, etc), so I'm not sure if adding the id and class here will make it seem cluttered or messy. Thoughts on this are welcome.
  • I tried triggering the Circle build a few times after random failures by using amended commits (I can't trigger a build directly in Circle), but none of them passed, so I will probably need some assistance with that. The relevant specs all pass locally.

@jonasjabari jonasjabari merged commit 4fc67cf into master Jun 4, 2019
@pascalwengerter pascalwengerter deleted the action-class-and-id-attrs branch June 21, 2019 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow @tag_attributes on action core component
2 participants