Implementing issue 83

[jonasjabari]

Issue #83: Link Component is broken

Changes

• fixed link component by removing the link_to helper from the link template
• replace it with simple a tag
• added specs

[cameronnorman]

@jonasjabari Would this possibly solve the anchor issue? I doubt it but thought I should ask before I attempt to fix it this evening

[cameronnorman]

I am happy with the code here and have tested it. Maybe add this to the link documents

Example 5

This example renders a link with a get request to an address with an anchor.

div id: "foo", class: "bar" do
  link path: "#anchor" text: "Go to the anchor"
  5.times do |i|
    br do ; end
  end
  div id: "anchor"
    plain "I'm an anchor point the link scrolls to"
  end
end

returns

<div id="foo" class="bar">
  <a href="#anchor">Here</a>
  <br />
  <br />
  <br />
  <br />
  <br />
  <div id="anchor">I'm an anchor point the link scrolls to</div>
</div>

[jonasjabari]

I need to test this again. A similar approach didn't work for me. I used the latest chrome browser, did you use a different browser?

[cameronnorman]

Yeah I used firefox

[jonasjabari]

Ok, then #4 might be only chrome browser related. but this PR aims to resolve #83
Do you have any feedback concerning the implemention towards #83 ?

If not, may you approve the PR?
We can than discuss #4 in its issue. :)