remove empty lines and reduce LOC #94
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasjabari
requested changes
Jul 28, 2019
There was a problem hiding this comment.
Everything looks nice. We should remove test coverage from PRs though and probably ignore it at all. I think only CI should be able to update the coverage files --> Will be covered when introducing the coverage badge. The CI should calculate the coverage for the PR's branch and after merging the resulting coverage of the target branch.
michaelrevans
approved these changes
Jul 31, 2019
|
Closed via #134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not belong to an issue
Changes
Notes