Skip to content

Simplify init of EventCollection. #15910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2020
Merged

Simplify init of EventCollection. #15910

merged 1 commit into from
Apr 1, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 11, 2019 •
edited
Loading

Rely on set_positions to set up the relevant arrays, and also numpyfy
it.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@timhoffm timhoffm added this to the v3.3.0 milestone Feb 16, 2020
Kojoley
Kojoley reviewed Feb 16, 2020
View reviewed changes
QuLogic
QuLogic requested changes Mar 9, 2020
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests should probably be extended a bit to encapsulate vertical orientation in the constructor, since that was buggy here.

@QuLogic
Copy link
Member

QuLogic commented Apr 1, 2020

Ping?

@anntzer
Simplify init of EventCollection.
799c7b9 
Rely on set_positions to set up the relevant arrays, and also numpyfy
it.
@anntzer
Copy link
Contributor Author

anntzer commented Apr 1, 2020

Sorry, fell off the radar. Extended a test too.

@timhoffm timhoffm merged commit 17ef13b into matplotlib:master Apr 1, 2020
@anntzer anntzer deleted the eventplotinit branch April 1, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kojoley Kojoley Kojoley left review comments

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @QuLogic @Kojoley @timhoffm