Shorten the type1-to-unicode name table. #16421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This table is actually only used as "uni2type1" to convert unicode characters to "Adobe Type 1" glyph names. In fact, "unknown" characters all get converted to "uni1234" where 1234 is `hex(ord(c))`; see e.g. https://blogs.adobe.com/CCJKType/2013/06/font-development-via-unicode.html Given that type12uni doesn't include *all* code points anyways, we may as well generate the "uni1234"-type names as needed instead. In both places where this is used, if we don't find "uni1234" in the table we already fallback to "question" (just below the patch).
timhoffm
approved these changes
Feb 5, 2020
|
What generates |
|
Probably a script lost in the mists of time... |
QuLogic
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This table is actually only used as "uni2type1" to convert unicode
characters to "Adobe Type 1" glyph names. In fact, "unknown" characters
all get converted to "uni1234" where 1234 is
hex(ord(c)); see e.g.https://blogs.adobe.com/CCJKType/2013/06/font-development-via-unicode.html
Given that type12uni doesn't include all code points anyways, we may
as well generate the "uni1234"-type names as needed instead. In both
places where this is used, if we don't find "uni1234" in the table we
already fallback to "question" (just below the patch).
PR Summary
PR Checklist