Skip to content

Deprecate unit_cube-related methods in Axes3D #24240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2022

Conversation

oscargus
Copy link
Member

PR Summary

I cannot see that there is any valid public use for these. No doc-string either.

PR Checklist

Tests and Styling

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe soften this to "...if you rely on this let us know and we will consider preserving"?

@oscargus
Copy link
Member Author

Maybe soften this to "...if you rely on this let us know and we will consider preserving"?

Doesn't that always hold?

(I checked on grep.app and one other library seems to use tunit_edges.)

@timhoffm
Copy link
Member

Doesn't that always hold?

Basically, yes. But people may not be aware of that. However, IMHO adding this is is only needed in cases where we ourselves have some doubts and consider it likely that there might be substantial downstream issues.

This here is good as is.

@timhoffm
Copy link
Member

@oscargus maybe you want to give the one known downstream user a heads up.

@timhoffm timhoffm merged commit b298423 into matplotlib:main Oct 22, 2022
@oscargus oscargus deleted the unitcubedeprecations branch October 22, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants