Cleanup Barbs._find_tails. #24290
Merged
Cleanup Barbs._find_tails. #24290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Oct 28, 2022
| mag = mag % full | ||
|
|
||
| mag = half * np.around(mag / half) | ||
| n_flags, mag = divmod(mag, flag) |
There was a problem hiding this comment.
AFAICS this would not work for non-array inputs.
There was a problem hiding this comment.
Indeed. However we only ever call this with actual arrays, so I just adjusted the docstring accordingly.
- numpydoc. - use np.around instead of manual rounding, and divmod instead of separate div and mod; cast to int at the end.
timhoffm
approved these changes
Oct 28, 2022
QuLogic
approved these changes
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst