DOC: Improve colormap normalization example #27729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Feb 1, 2024
galleries/examples/images_contours_and_fields/colormap_normalizations.py
Outdated
Show resolved
Hide resolved
galleries/examples/images_contours_and_fields/colormap_normalizations.py
Outdated
Show resolved
Hide resolved
|
It would also be nice to fix the colorbar tick labels for the symlog case (see the relevant example). |
timhoffm
approved these changes
Feb 2, 2024
|
Doc build failure is unrelated (see #27736) - sorry for the fuzz. |
timhoffm
reviewed
Feb 2, 2024
galleries/examples/images_contours_and_fields/colormap_normalizations.py
Outdated
Show resolved
Hide resolved
- Turn each norm into a headed section. - Link to each norm directly in text. - Consistently use `Z` as data variable, and pass norms (or `vmin`) in the same order for every example. - Label the colour bars. - Tweak some descriptions to be clearer. - Change data for SymLogNorm and use it for the custom norm and BoundaryNorm, in order to match their descriptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Zas data variable, and pass norms (orvmin) in the same order for every example.Fixes [Doc]: Text in the colormap normalization gallery doesn't match the code #27727
PR checklist