I2C pinmap and HAL fixes for MIMXRT #150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Impact of changes
This should fix some issues initializing and using I2C on the MIMXRT. In particular, the pins labeled as I2C on the Teensy should now be usable.
Note: Unfortunately, NACKs in address bytes are still not detected using the single-byte I2C API, and I'm not sure that this is possible to fix (the hardware seems to just wait a long time before sending the NACK flag).
Migration actions required
Documentation
None
Pull request type
Test results
I ran the I2C test suite with the test shield and it passed except for the full-chip EEPROM test (infinite hang) and the single-byte incorrect address test. I will look into those later...
Reviewers