Skip to content

I2C pinmap and HAL fixes for MIMXRT #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Conversation

multiplemonomials
Copy link
Collaborator

@multiplemonomials multiplemonomials commented Mar 9, 2023

Summary of changes

  • All missing I2C pin mappings added to the pin map table, enabling any and all MIMXRT105x I2C pins to be used
  • Fixed timing issue where the transactional API would not detect a NACK in the address byte, making it look like the slave acknowledged when it didn't

Impact of changes

This should fix some issues initializing and using I2C on the MIMXRT. In particular, the pins labeled as I2C on the Teensy should now be usable.

Note: Unfortunately, NACKs in address bytes are still not detected using the single-byte I2C API, and I'm not sure that this is possible to fix (the hardware seems to just wait a long time before sending the NACK flag).

Migration actions required

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

I ran the I2C test suite with the test shield and it passed except for the full-chip EEPROM test (infinite hang) and the single-byte incorrect address test. I will look into those later...


Reviewers


@multiplemonomials
Copy link
Collaborator Author

@wwatson4506 Have you had a chance to look at this one?

Copy link

@wwatson4506 wwatson4506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, some how I missed this one...

@multiplemonomials multiplemonomials merged commit e93b80a into master Mar 22, 2023
@multiplemonomials multiplemonomials deleted the dev/mimxrt-i2c-fixup branch March 22, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants