Skip to content

Support component versioning #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 17, 2022
Merged

Support component versioning #7

merged 10 commits into from
Feb 17, 2022

Conversation

mdingena
Copy link
Owner

Context

After a recent game update, decoding strings stopped working. This is because the Pickup component has been updated to contain additional data. These strings contained that data but the Pickup decoder did not read it properly, causing bit misalignment.

Strings come with component versioning. The transcoder was already writing this component versioning after encoding, but decoding doesn't handle any of that; it always assumes the version it knows is the version we're getting from the game.

Changes

  • Added a version parsing function.
  • Added version support to each component, allowing the decoders to conditionally read data from the string depending on which version component it's getting.

@mdingena mdingena merged commit fa9a922 into main Feb 17, 2022
@mdingena mdingena deleted the support-component-versioning branch February 17, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant