Merge #111

111: Removed unreachable code r=bidoubiwa a=sanders41

In both cases where I removed the `sys.exit` line there is a `raise` immediately preceding it so it is impossible to reach the `sys.exit`

Co-authored-by: Paul Sanders <[email protected]>

Author: bors[bot]

scraper/src/config/config_loader.py

@@ -8,7 +8,6 @@
 from collections import OrderedDict
 import json
 import os
-import sys
 import copy
 
 from .config_validator import ConfigValidator
@@ -102,7 +101,6 @@ def _load_config(self, config):
             return data
         except ValueError as value_error:
             raise ValueError('CONFIG is not a valid JSON') from value_error
-            sys.exit(EXIT_CODE_WRONG_CONFIG)
 
     def _parse(self):
         # Parse Env

scraper/src/documentation_spider.py

@@ -10,7 +10,6 @@
 from scrapy.spiders.sitemap import regex
 import re
 import os
-import sys
 
 # End of import for the sitemap behavior
 
@@ -160,7 +159,6 @@ def add_records(self, response, from_sitemap):
             self.reason_to_stop = "Too much hits, Docs-Scraper only handle {} records".format(
                 int(self.nb_hits_max))
             raise ValueError(self.reason_to_stop)
-            sys.exit(EXIT_CODE_EXCEEDED_RECORDS)
 
     def parse_from_sitemap(self, response):
         if self.reason_to_stop is not None: