Removed unreachable code #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
reviewed
Mar 31, 2021
Closed
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Apr 2, 2021
111: Removed unreachable code r=bidoubiwa a=sanders41 In both cases where I removed the `sys.exit` line there is a `raise` immediately preceding it so it is impossible to reach the `sys.exit` Co-authored-by: Paul Sanders <[email protected]>
|
Build failed: |
tryBuild failed: |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild succeeded: |
|
bors merge |
|
Build succeeded: |
curquiza
added
the
skip-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In both cases where I removed the
sys.exitline there is araiseimmediately preceding it so it is impossible to reach thesys.exit