Skip to content

Removed unreachable code #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2021
Merged

Removed unreachable code #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d34fce4
Removed unreachable code
sanders41 Mar 31, 2021
86e689a
Removing unused imports
sanders41 Mar 31, 2021
eccbf4f
Merge remote-tracking branch 'upstream/main' into unreachable
sanders41 Mar 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ src/strategies/__pycache__/
*.pyc
.env
update.sh
.python-version

*yarn.lock

Expand Down
2 changes: 0 additions & 2 deletions scraper/src/config/config_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
from collections import OrderedDict
import json
import os
import sys
import copy

from .config_validator import ConfigValidator
Expand Down Expand Up @@ -102,7 +101,6 @@ def _load_config(self, config):
return data
except ValueError as value_error:
raise ValueError('CONFIG is not a valid JSON') from value_error
sys.exit(EXIT_CODE_WRONG_CONFIG)

def _parse(self):
# Parse Env
Expand Down
2 changes: 0 additions & 2 deletions scraper/src/documentation_spider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
from scrapy.spiders.sitemap import regex
import re
import os
import sys

# End of import for the sitemap behavior

Expand Down Expand Up @@ -160,7 +159,6 @@ def add_records(self, response, from_sitemap):
self.reason_to_stop = "Too much hits, Docs-Scraper only handle {} records".format(
int(self.nb_hits_max))
raise ValueError(self.reason_to_stop)
sys.exit(EXIT_CODE_EXCEEDED_RECORDS)

def parse_from_sitemap(self, response):
if self.reason_to_stop is not None:
Expand Down