Skip to content

Adding config info to allow urls with ports #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2021
Merged

Adding config info to allow urls with ports #112

merged 3 commits into from
Mar 31, 2021

Conversation

sanders41
Copy link
Collaborator

Closes #103

curquiza
curquiza previously approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @sanders41!

I let @bidoubiwa review before any merge 🙂

@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Mar 31, 2021
@bidoubiwa bidoubiwa self-requested a review March 31, 2021 11:01
@bidoubiwa
Copy link
Contributor

bidoubiwa commented Mar 31, 2021 •
edited
Loading

Hey @sanders41 thanks a lot! This is really great information. Unfortunately I could not make it work. Do you have an example config file with localhost that works?

Nevermind it worked! I had to use the build instead of the dev mode. I will try with your other parameters.

bidoubiwa
bidoubiwa reviewed Mar 31, 2021
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of this addition?

bidoubiwa
bidoubiwa previously approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Thanks so much for the investigation. This is really great and needed information for our different CI's.

🔥🔥🔥🔥

@sanders41
Copy link
Collaborator Author

Yes, I like your update. When I saw your initial message my first though was a ChromeDriver path issue so your updated instructions will explain that better.

curquiza
curquiza requested changes Mar 31, 2021
View reviewed changes
bidoubiwa
bidoubiwa reviewed Mar 31, 2021
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 🔥 LGTM

@curquiza
Copy link
Member

Thanks again for your PR @sanders41! 🚀

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 31, 2021

Build succeeded:

@bors bors bot merged commit db012ed into meilisearch:main Mar 31, 2021
@sanders41 sanders41 deleted the url_port branch March 31, 2021 20:10
@bidoubiwa bidoubiwa mentioned this pull request Apr 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa left review comments

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs-scraper not working when url has a port
3 participants
@sanders41 @bidoubiwa @curquiza