Skip to content

Adding support for Python 3.9 #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Conversation

sanders41
Copy link
Collaborator

Closes #115

Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this PR! Just a small question

@bidoubiwa
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request Apr 14, 2021
@bidoubiwa
Copy link
Contributor

The pending tests comes from bors! They are required for bors to accept the merge but since they changed name bors is still waiting for these non-existent tests.

In bors.toml you have to change integrations-tests with both integration-tests (3.8) and integration-tests (3.9)
and change unit-tests with the same logic

status = ['unit-tests', 'integration-tests', 'linter', 'image-build']
# 1 hour timeout
timeout-sec = 3600

@sanders41
Copy link
Collaborator Author

sanders41 commented Apr 14, 2021

@bidoubiwa I updated bors, but none of the tests are running. Based on the bors update I am assuming I should pull in the latest merge to main to pick up the new CI tests?

Sorry, never mind. Everything was sitting on yellow for a long time, but it has started now (and I was thinking the wrong PR 😄).

@bidoubiwa
Copy link
Contributor

bidoubiwa commented Apr 14, 2021

I'm wondering why these tests keep comming back. @curquiza any idea? I think they might have to be changed inside the settings of this repo as well

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the settings in the repo! :)

@bidoubiwa
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Apr 14, 2021

@bors bors bot merged commit ec23e4c into meilisearch:main Apr 14, 2021
@sanders41 sanders41 deleted the python_versions branch April 14, 2021 13:00
@bors
Copy link
Contributor

bors bot commented Apr 14, 2021

try

Timed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support python 3.9
3 participants