Skip to content

Add authentication with Keycloak for scraping #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2020

Conversation

spahrson
Copy link
Contributor

This PR add the ability to authenticate by Keycloak.

@spahrson spahrson force-pushed the feature/keycloak_authentication branch from db1fb13 to 0ffeae8 Compare October 22, 2020 12:27
@curquiza
Copy link
Member

Hello @spahrson!
Thanks for this PR, it seems to be a great addition! I don't know keycloak, can you tell me a little bit about it? What is your usage of keycloak for example?
I will discuss about it with the team and I will come back to you before the end of the week 🙂 But it should be ok!

@spahrson
Copy link
Contributor Author

Hi @curquiza.

Keycloak is a open source identity and access management solution. It can act as an OAuth 2.0 and OpenID connect compliant authorization server and there is a proxy called Gatekeeper to protect non-oauth compliant applications. We use Keycloak as Single-Sign-on solution. We use antora for documentation and meilisearch to search our documentation. Our antora instances are protected by Keycloak. So we need the ability to scrape antora for meilisearch using an OAuth 2.0 Bearer-Token. This PR fullfills this requirement for Keycloak.

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your PR, I request some small changes but the general work is really good 🙂


I don't know if you already know this on GitHub but here is my tip: you can accept the change suggestions directly on the GitHub interface here (this is an example):
Capture d’écran 2020-09-30 à 12 59 48

Ramon Spahr and others added 2 commits October 29, 2020 19:51
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @spahrson! Thanks for your reactivity!!

@curquiza
Copy link
Member

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 29, 2020

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants