Configure prettier #354
Merged
Configure prettier #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
added
the
skip-changelog
|
bors try |
tryBuild succeeded: |
bidoubiwa
suggested changes
Jun 8, 2021
There was a problem hiding this comment.
In the contributing.md there is still the following:
# Linter with auto-correct
yarn lint-fix
# Prettier for Markdown (auto-correct)
yarn format:md
# Prettier for SCSS (auto-correct)
yarn format:scss
Could you change the lint-fix and also test the format to see if they work properly?
|
Also in the contributing.md apparently the linter recognizes that the code is So you have the following at the bottom of the file: Could you replace the double quotes with simple quotes? |
Nice catch ! I tested them and they work perfectly 👌 |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's wrong ?
Prettier was installed but the rules weren't configured properly. There was different coding styles in different files. Lack of uniformity.
What's inside this PR ?
Edit of the configuration file, and formatting of every file regarding the same specification.
Please take a look at the rules to see if it seems coherent to you 🙏