-
Notifications
You must be signed in to change notification settings - Fork 30
Add option to enable/disable dark mode #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d33b03a
to
2fe9d04
Compare
bors try |
tryMerge conflict. |
42155a0
to
95eab70
Compare
bidoubiwa
reviewed
Jun 9, 2021
bidoubiwa
suggested changes
Jun 9, 2021
Co-authored-by: cvermand <[email protected]>
bidoubiwa
approved these changes
Jun 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
bors try |
tryBuild succeeded: |
bors try |
tryBuild succeeded: |
bors merge |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #341
What's wrong ?
If a user has his preferences set to dark mode, but the website using
docs-searchbar
don't have support for dark mode, the website will appear in light mode except for the searchbar, which will appear in dark mode.What's inside this PR
This PR adds an option
enableDarkMode
to allow users enable dark mode on the searchbar. It is set tofalse
by default.How to test
To switch between dark and light mode, go to
System Preferences
in your mac and thenGeneral
.To run the project:
yarn && yarn playground
and go tohttp://localhost:1234/
You can also try the searchbar with the option
layout: simple
if you want to !Light mode
Just run the project, and switch between light & dark mode in your system preferences.
Dark mode
Go to the project, and add
enableDarkMode: true
to the playground you want to use.Example in
playgrounds/html/index.html
:Screenshots
Light mode:

Dark mode with
enableDarkMode
set totrue
:Dark mode without
enableDarkMode
:enableDarkMode
isn't set