Skip to content

Dark mode simplification #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 15, 2021
Merged

Dark mode simplification #366

merged 12 commits into from
Jun 15, 2021

Conversation

mdubus
Copy link
Member

@mdubus mdubus commented Jun 14, 2021

No description provided.

@bidoubiwa
Copy link
Contributor

bidoubiwa commented Jun 14, 2021 •
edited
Loading

  • No automatic changes in modes -> create issue. How to handle
@media (prefers-color-scheme: dark) {
}
  • No css when enhancedSearchInput: true is not set to true
  • Placeholder not same position is different modes
  • 2 second delay (found by @mdubus)

@mdubus mdubus force-pushed the dark_mode_simplification branch from d51ea20 to eb2e428 Compare June 14, 2021 12:09
@netlify
Copy link

netlify bot commented Jun 14, 2021 •
edited
Loading

✔️ Deploy Preview for docs-searchbar-preview ready!

🔨 Explore the source changes: eb2e428

🔍 Inspect the deploy log: https://app.netlify.com/sites/docs-searchbar-preview/deploys/60c746f06ad462000725e8f6

😎 Browse the preview: https://deploy-preview-366--docs-searchbar-preview.netlify.app/

bidoubiwa
bidoubiwa suggested changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

bidoubiwa
bidoubiwa suggested changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the index.html and index.js from the js playground to match the one from the default playground?

searchbox and docs-searchbar class should be removed
and you can add enableDarkMode and enhancedSearchInput: true,

bidoubiwa
bidoubiwa suggested changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some JavaScript improvements

@mdubus mdubus marked this pull request as ready for review June 14, 2021 14:26
bidoubiwa
bidoubiwa suggested changes Jun 14, 2021
View reviewed changes
mdubus and others added 2 commits June 14, 2021 16:39
@mdubus mdubus requested a review from bidoubiwa June 14, 2021 15:04
bidoubiwa
bidoubiwa suggested changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change in assets position

bidoubiwa
bidoubiwa approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥🔥 incredible work

@mdubus
Copy link
Member Author

mdubus commented Jun 15, 2021

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 15, 2021

🔒 Permission denied

Existing reviewers: click here to make mdubus a reviewer

@bidoubiwa
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 15, 2021

Build succeeded:

@bors bors bot merged commit 94490e2 into main Jun 15, 2021
@bors bors bot deleted the dark_mode_simplification branch June 15, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdubus @bidoubiwa