Skip to content

Replace float positioning with flex boxes #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Replace float positioning with flex boxes #383

merged 1 commit into from
Jul 12, 2021

Conversation

mdubus
Copy link
Member

@mdubus mdubus commented Jul 1, 2021

Replacement of the floats inside the CSS, with something less eye-breaking 🙈

Please make sure to test both in default and simple layout that it doesn't break anything ❤️

@mdubus mdubus added the skip-changelog The PR will not appear in the release changelogs label Jul 1, 2021
@mdubus mdubus requested a review from bidoubiwa July 1, 2021 14:10
@bidoubiwa bidoubiwa changed the title Replace floats in style Replace float positioning with flex boxes Jul 12, 2021
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@bidoubiwa
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 12, 2021

Build succeeded:

@bors bors bot merged commit 8289145 into main Jul 12, 2021
@bors bors bot deleted the refactor_code branch July 12, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants