Skip to content

Remove api key from mandatory config #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 23, 2021
Merged

Remove api key from mandatory config #424

merged 5 commits into from
Sep 23, 2021

Conversation

bidoubiwa
Copy link
Contributor

No description provided.

@bidoubiwa bidoubiwa requested a review from alallema September 22, 2021 23:04
alallema
alallema previously approved these changes Sep 23, 2021
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we update the README to say apiKey is optional? :)

@bidoubiwa bidoubiwa requested a review from curquiza September 23, 2021 09:45
@bidoubiwa
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Sep 23, 2021
424: Remove api key from mandatory config r=bidoubiwa a=bidoubiwa



Co-authored-by: Charlotte Vermandel <[email protected]>
Co-authored-by: cvermand <[email protected]>
@bors
Copy link
Contributor

bors bot commented Sep 23, 2021

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@bidoubiwa
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 23, 2021

Build succeeded:

@bors bors bot merged commit 1af96f5 into main Sep 23, 2021
@bors bors bot deleted the fix_arguments_check branch September 23, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants