Skip to content

Setting up the Cypress with first test #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Oct 14, 2021

Conversation

TheLaw1337
Copy link
Contributor

No description provided.

@TheLaw1337 TheLaw1337 marked this pull request as draft October 5, 2021 14:44
@TheLaw1337
Copy link
Contributor Author

TheLaw1337 commented Oct 6, 2021

I have a problem with eslint which returns one error:
C:\meilisearch\docs-searchbar.js\cypress\plugins\index.js
19:1 error Expected "export" or "export default" import/no-commonjs

This file is generated byCypress as a placeholder for custom actions and I did nothing inside. WDYT?
@curquiza

@bidoubiwa
Copy link
Contributor

Could you add every cypress directory except integration into the .gitignore ? These file can be ignored as they are placeholders.
Otherwise we would have to create multiple eslint rules for multiple parts of our project

@TheLaw1337
Copy link
Contributor Author

Could you add every cypress directory except integration into the .gitignore ? These file can be ignored as they are placeholders. Otherwise we would have to create multiple eslint rules for multiple parts of our project

They are already in .gitignore

############################
# CYPRESS
############################
cypress/screenshots
cypress/videos
cypress/support
cypress/plugins
cypress/fixtures

@bidoubiwa
Copy link
Contributor

You can add it in the .eslintignore! If the error comes from eslint of course :)

@TheLaw1337
Copy link
Contributor Author

You can add it in the .eslintignore! If the error comes from eslint of course :)

.eslintignore updated :)

Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove package-lock.json as we use yarn.loc instead!

@TheLaw1337
Copy link
Contributor Author

Could you remove package-lock.json as we use yarn.loc instead!

Done. Sorry for that - I'm accustomed to using npm and that's the first project where yarn is used instead of npm.

@bidoubiwa
Copy link
Contributor

No problem :) I prefer yarn as it is faster.

Could you pass your PR in ready for review ?
Screenshot 2021-10-12 at 12 34 47

@TheLaw1337 TheLaw1337 marked this pull request as ready for review October 14, 2021 09:32
@TheLaw1337
Copy link
Contributor Author

No problem :) I prefer yarn as it is faster.

Could you pass your PR in ready for review ? Screenshot 2021-10-12 at 12 34 47

Done

@TheLaw1337 TheLaw1337 requested a review from bidoubiwa October 14, 2021 09:43
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this PR 🔥🔥🔥

If you are participating in Hacktoberfest, and you would like to receive a small gift from MeiliSearch too, please complete this form.

@bidoubiwa
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 14, 2021

Build succeeded:

@bors bors bot merged commit f304033 into meilisearch:main Oct 14, 2021
@bidoubiwa bidoubiwa added hacktoberfest-accepted skip-changelog The PR will not appear in the release changelogs labels Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants