Skip to content

Extend checkArguments to cover all arguments #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 18, 2021

Conversation

ColinFrick
Copy link
Contributor

@ColinFrick ColinFrick commented Oct 14, 2021

The PR extends the checkArguments method to cover all arguments. Additionally I added all arguments to the jsdoc.

Closes #351

@ColinFrick ColinFrick marked this pull request as ready for review October 18, 2021 06:49
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this great PR @ColinFrick! It is perfect as it is :) 🔥

@bidoubiwa
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 18, 2021

Build succeeded:

@bors bors bot merged commit 579e882 into meilisearch:main Oct 18, 2021
@curquiza curquiza changed the title feat: extend checkArguments to cover all arguments Extend checkArguments to cover all arguments Oct 18, 2021
@bidoubiwa
Copy link
Contributor

If you are participating in Hacktoberfest, and you would like to receive a small gift from MeiliSearch too, please complete this form.

@ColinFrick ColinFrick deleted the fix/351 branch October 18, 2021 15:26
@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

function checkArguments only checks a few arguments
3 participants