Migrate to dart-sass, update divisions

[ColinFrick]

Migrate from node-sass to (dart-) sass. Replace divisions with multiplications or math.div

Closes #344

[ColinFrick]

I verified the resulting css. It changes the quotation marks from double to single quotes. It also adds them to the attribute selectors.

The published scss in npm (dist/npm) would be incompatible to any project using node-sass as it's compiler. Is this ok? Or should the scss be compatible?

I also saw that with commit abb37a3 all packages were installed from the npmjs registry instead of the yarn registry. Is this correct? Should I also change my project registry to https://registry.npmjs.org/ ?

[bidoubiwa]

I also saw that with commit abb37a3 all packages were installed from the npmjs registry instead of the yarn registry. Is this correct? Should I also change my project registry to https://registry.npmjs.org/ ?

This is a mistake! I'm asking for its removal :)

[bidoubiwa]

The published scss in npm (dist/npm) would be incompatible to any project using node-sass as it's compiler. Is this ok? Or should the scss be compatible?

So to make it work for our users, they will have to make the migration to dart-saas as well? Is it possible to make it compilable with node-sass while removing the deprecated package?

[ColinFrick]

The published scss in npm (dist/npm) would be incompatible to any project using node-sass as it's compiler. Is this ok? Or should the scss be compatible?

So to make it work for our users, they will have to make the migration to dart-saas as well? Is it possible to make it compilable with node-sass while removing the deprecated package?

Exactly. If a user uses the library with @import "~docs-searchbar.js/dist/npm/styles/main"; they would be required to use dart-sass. I replaced math.div with multiplications where possible. But the even-px function requires division to remove the unit.

So we have two options: Require dart-sass from the user or ignore the deprecations for now with the --no-deps option.
(I have already updated the PR with --no-deps)
It still compiles, until dart-sass 2.0.0 is released (whenever that might be)

[bidoubiwa]

I think we should plan ahead and remove compatibility with node-sass. It is already deprecated. What do you think?

[ColinFrick]

@bidoubiwa I concur. I have reverted the changes. You can review the changes now.

[bidoubiwa]

The PR is great! 🔥🔥 Thanks for your involvement.

Maybe you already completed the form as per the previous merged PR, but just in case:
if you are participating in Hacktoberfest, and you would like to receive a small gift from MeiliSearch too, please complete this form.

[bidoubiwa]

bors merge

[bors]

Build succeeded:

• linter-check
• Tests (Node.js 12)
• Tests (Node.js 14)