-
Notifications
You must be signed in to change notification settings - Fork 30
Updated cypress tests for when search query doesn't have any results … #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…and placeholder text check
Thanks for you contribution 🔥:) Inside the results box could you test the rendering of all the sub parts? At least of one result |
There is an existing test that does this already. |
It only test one heading! It does not tests if the other sub-headings render correctly cy.get('div.dsb-suggestion:nth-child(1)') // the first entry should be "Quick start"
.contains('Quick start') |
|
@bidoubiwa I have added a test to check remaining subheadings! I don't see any |
Oh I just saw that cypress tests are not appearing in the checks of this CI but do appear in all the other bumps CI we have. |
Could you update your branch with main? Cypress CI tests are not triggered automatically |
@bidoubiwa I have updated my branch and updated the comments on the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥 Thanks a lot
If you are participating in Hacktoberfest, and you would like to receive a small gift from MeiliSearch too, please complete this form. |
bors merge |
Build succeeded: |
…and placeholder text check
Fixes: #339