Skip to content

Updated cypress tests for when search query doesn't have any results … #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 19, 2021

Conversation

devcer
Copy link
Contributor

@devcer devcer commented Oct 17, 2021

…and placeholder text check

Fixes: #339

@bidoubiwa
Copy link
Contributor

bidoubiwa commented Oct 18, 2021

Thanks for you contribution 🔥:) Inside the results box could you test the rendering of all the sub parts? At least of one result

@devcer
Copy link
Contributor Author

devcer commented Oct 18, 2021

Thanks for you contribution 🔥:) Inside the results box could you test the rendering of all the sub parts? At least of one result

There is an existing test that does this already.

@bidoubiwa
Copy link
Contributor

bidoubiwa commented Oct 18, 2021

It only test one heading! It does not tests if the other sub-headings render correctly

    cy.get('div.dsb-suggestion:nth-child(1)') // the first entry should be "Quick start"
      .contains('Quick start')

@bidoubiwa
Copy link
Contributor

bidoubiwa commented Oct 18, 2021

Could you remove package-lock.json ?

@devcer
Copy link
Contributor Author

devcer commented Oct 18, 2021

@bidoubiwa I have added a test to check remaining subheadings! I don't see any package-lock.json in my commit. where do you see it?

@bidoubiwa
Copy link
Contributor

bidoubiwa commented Oct 19, 2021

Oh I just saw that cypress tests are not appearing in the checks of this CI but do appear in all the other bumps CI we have.
There seem to be a permission issue with the test run.
I'm fixing this

@bidoubiwa
Copy link
Contributor

bidoubiwa commented Oct 19, 2021

Could you update your branch with main? Cypress CI tests are not triggered automatically

@devcer
Copy link
Contributor Author

devcer commented Oct 19, 2021

@bidoubiwa I have updated my branch and updated the comments on the tests.

@devcer devcer requested a review from bidoubiwa October 19, 2021 15:18
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥 Thanks a lot

@bidoubiwa
Copy link
Contributor

If you are participating in Hacktoberfest, and you would like to receive a small gift from MeiliSearch too, please complete this form.

@bidoubiwa
Copy link
Contributor

bors merge

@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Oct 19, 2021
@bors
Copy link
Contributor

bors bot commented Oct 19, 2021

@bors bors bot merged commit fd260bb into meilisearch:main Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add browser tests with Cypress
2 participants