Automatic dark/light mode toggle, force dark mode

[ColinFrick]

This adds a new event listener to the color scheme, and always as a third option for enableDarkMode

Any objection against the option value always? It could also be force or something like that?
What do you think?

Closes #369

[bidoubiwa]

Could you update your branch with main? Cypress CI tests are not triggered automatically

[ColinFrick]

Could you update your branch with main? Cypress CI tests are not triggered automatically

Done

[bidoubiwa]

What do you think of auto instead of always ?

[ColinFrick]

Wouldn't auto suggest automatically changing between dark / light mode? That would currently be true.

[bidoubiwa]

I think auto implies that it will either go for light or dark based on the user's preferences. false implies that it will always be light and true that it will always be dark. At least this is how I see it. Thus always means that it will be always dark.

The naming of enableDarkMode may not be the best. Until we find a better naming I think auto is more suitable.

[ColinFrick]

That would be a breaking change right? Until now true meant set dark/light mode to system mode.

[bidoubiwa]

That would be a breaking change right? Until now true meant set dark/light mode to system mode.

Oke indeed you are right! I misunderstood the PR.

So just to be sure, the difference between the modes as for now is:

• false: always light mode
• true: system mode (light or dark)
• auto: Always dark mode?

[ColinFrick]

I changed the PR according to your suggestion:

• false: always light mode
• true: always dark mode
• auto: system mode (light or dark)

[bidoubiwa]

That seems like the best option! I will review the code ASAP :) Probably not today

[ColinFrick]

@bidoubiwa thank you for the input. I have changed it accordingly.

[bidoubiwa]

LGTM 🔥 Thanks for this PR. This was very very needed 🎉

For the 200'th time 😂 If you are participating in Hacktoberfest, and you would like to receive a small gift from MeiliSearch too, please complete this form.

Thanka so much for you involvement and you great PR's

[bidoubiwa]

bors merge

[bors]

Build succeeded:

• cypress-run
• linter-check
• Tests (Node.js 12)
• Tests (Node.js 14)