Skip to content

Changes related to the next MeiliSearch release (v0.25.0) #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jan 31, 2022
Merged

Changes related to the next MeiliSearch release (v0.25.0) #501

merged 15 commits into from
Jan 31, 2022

Conversation

meili-bot
Copy link
Contributor

This PR gathers the changes related to the next MeiliSearch release (v0.25.0) so that this package is ready when the official release is out.

⚠️ This PR should NOT be merged until:

  • the next release of MeiliSearch (v0.25.0) is out.
  • the meilisearch-js dependency has been released to be compatible with MeiliSearch v0.25.0.
    Once the release is out, the upgrade of the meilisearch-js dependency might be committed to this branch.

This PR is auto-generated for the pre-release week purpose.

@meili-bot meili-bot added the skip-changelog The PR will not appear in the release changelogs label Dec 6, 2021
@bidoubiwa
Copy link
Contributor

⚠️ Before Merge ⚠️

Update version of meilisearch-js to latest non-beta version!

@bidoubiwa bidoubiwa marked this pull request as ready for review January 10, 2022 17:09
@bidoubiwa bidoubiwa requested a review from alallema January 10, 2022 17:28
alallema
alallema reviewed Jan 12, 2022
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question about the version of the dependency of the js package

@curquiza curquiza added breaking-change The related changes are breaking for the users and removed skip-changelog The PR will not appear in the release changelogs labels Jan 12, 2022
@curquiza
Copy link
Member

curquiza commented Jan 12, 2022 •
edited
Loading

Breaking because will use meilisearch-js v0.24.0 that only works with MeiliSearch v0.25.0 and later -> it enforces the users to upgrade their MeiliSearch version

EDIT: enhancement label instead -> not breaking regarding the docs-searchbar API, but still need to increase the minor because we enforce to change the MeiliSearch version

@curquiza
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jan 12, 2022
@bors
Try #501:
8eb6e51
@bors
Copy link
Contributor

bors bot commented Jan 12, 2022

try

Build failed:

@curquiza curquiza added enhancement New feature or request and removed breaking-change The related changes are breaking for the users labels Jan 12, 2022
alallema
alallema previously approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍥

@curquiza
Copy link
Member

curquiza commented Jan 12, 2022 •
edited
Loading

LNGTC = looks not good to cypress 😢

@curquiza
Copy link
Member

curquiza commented Jan 13, 2022 •
edited
Loading

Blocked because of this: #519
Sorry if I'm wrong

@ghost
Copy link

ghost commented Jan 31, 2022

Is there any more progress on this or a workaround for the current version of docs-searchbar.js? I'm looking to upgrade to the latest meilisearch release v0.25

@bidoubiwa
Copy link
Contributor

Hey @cole-flexsim i'm trying to publish it today !

@ghost
Copy link

ghost commented Jan 31, 2022

@bidoubiwa Wow perfect timing! Thank you very much!

@bidoubiwa bidoubiwa force-pushed the bump-meilisearch-v0.25.0 branch from 920bda2 to 1a6f643 Compare January 31, 2022 15:39
@bors @bidoubiwa
Merge #537
5cd5a88 
537: Update logo after rebranding r=bidoubiwa a=bidoubiwa



Co-authored-by: Charlotte Vermandel <[email protected]>
Co-authored-by: cvermand <[email protected]>
alallema
alallema approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bidoubiwa
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 31, 2022

Build succeeded:

@bors bors bot merged commit a8904cc into main Jan 31, 2022
@bors bors bot deleted the bump-meilisearch-v0.25.0 branch January 31, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alallema alallema alallema approved these changes

@brunoocasali brunoocasali Awaiting requested review from brunoocasali

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@meili-bot @bidoubiwa @curquiza @alallema