Skip to content

feat: accept dom element #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2022
Merged

feat: accept dom element #653

merged 1 commit into from
Oct 4, 2022

Conversation

ColinFrick
Copy link
Contributor

Pull Request

Related issue

Fixes #652

What does this PR do?

  • Accept dom element with property inputElement

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

bidoubiwa
bidoubiwa approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ColinFrick, this is a very nice PR 🔥

this LGTM

@bidoubiwa
Copy link
Contributor

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Oct 4, 2022

Build succeeded:

@meili-bors meili-bors bot merged commit 22b4183 into meilisearch:main Oct 4, 2022
@bidoubiwa
Copy link
Contributor

Thanks again for contributing with Meilisearch ❤️
If you are participating in Hacktoberfest, and you would like to receive a small gift from Meilisearch too, don't forget to fill this form.

@bidoubiwa bidoubiwa added the enhancement New feature or request label Oct 4, 2022
@JaySunSyn
Copy link

Thanks for the quick turnaround @ColinFrick

@ColinFrick ColinFrick deleted the feat/652 branch October 4, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Shadow Dom support
3 participants
@ColinFrick @bidoubiwa @JaySunSyn