add typo tolerance to Meilisearch 101 #1683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryamsulemani97
commented
Jun 8, 2022
maryamsulemani97
commented
Jun 8, 2022
maryamsulemani97
requested review from
dichotommy and
guimachiavelli
and removed request for
dichotommy
dichotommy
reviewed
Jun 9, 2022
maryamsulemani97
commented
Jun 9, 2022
| - Disable typos on specific words | ||
| - Disable typos on specific attributes | ||
|
|
||
| Meilisearch accepts one typo for query terms containing `5` or more characters by default. If you search the movies index for `swaj`, you will not get any results. |
There was a problem hiding this comment.
Should we be referring to 5 as 5? On a quick read I briefly thought that 5 was a search term.
There was a problem hiding this comment.
I used 5 here because the typo tolerance guide mostly uses backticks for number of characters
There was a problem hiding this comment.
I think it makes sense to use backticks in the context of typo tolerance since we're speaking indirectly about the value of minWordSizeForTypos.
dichotommy
reviewed
Jun 14, 2022
| - Disable typos on specific words | ||
| - Disable typos on specific attributes | ||
|
|
||
| Meilisearch accepts one typo for query terms containing `5` or more characters by default. If you search the movies index for `swaj`, you will not get any results. |
There was a problem hiding this comment.
I think it makes sense to use backticks in the context of typo tolerance since we're speaking indirectly about the value of minWordSizeForTypos.
Co-authored-by: Tommy <[email protected]>
Co-authored-by: Tommy <[email protected]>
dichotommy
approved these changes
Jun 14, 2022
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1678