Skip to content

add getting_started_communicating_with_a_protected_instance to getting started #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 14, 2022

Conversation

maryamsulemani97
Copy link
Contributor

No description provided.

@dichotommy
Copy link
Contributor

Tell me if you think I'm being crazy... but it seems like a useful code sample to me. It shows how to search on movies with an API key for authorization. I think we can find a place for it outside of the 101.

What do you think about adding this sample at the end of the security section of the getting started? We can turn the warning that's currently present there into regular text and use it to introduce the code sample: "The master key should only be used for retrieving and managing API keys. For regular API calls, such as search, use an API key:"

@maryamsulemani97 maryamsulemani97 changed the title remove getting_started_communicating_with_a_protected_instance add getting_started_communicating_with_a_protected_instance to getting started Jun 13, 2022
Copy link
Contributor

@dichotommy dichotommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 🛡️ 🔑 👌🏻

@maryamsulemani97
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 14, 2022

Build succeeded:

@bors bors bot merged commit 3408a02 into master Jun 14, 2022
@bors bors bot deleted the remove-code-sample branch June 14, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants