-
Notifications
You must be signed in to change notification settings - Fork 90
Support localized-attributes settings #1060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
meili-bors
merged 4 commits into
meilisearch:main
from
ellnix:language-settings-and-search-parameter-1011
Jan 16, 2025
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
tests/settings/test_settings_localized_attributes_meilisearch.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
from typing import List | ||
|
||
from meilisearch.models.index import LocalizedAttributes | ||
|
||
NEW_LOCALIZED_ATTRIBUTES = [{"attributePatterns": ["title"], "locales": ["eng"]}] | ||
ellnix marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
|
||
def unpack_loc_attrs_response(response: List[LocalizedAttributes]): | ||
return [loc_attrs.model_dump(by_alias=True) for loc_attrs in response] | ||
sanders41 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
|
||
def test_get_localized_attributes(empty_index): | ||
"""Tests getting default localized_attributes.""" | ||
response = empty_index().get_localized_attributes() | ||
assert response is None | ||
|
||
|
||
def test_update_localized_attributes(empty_index): | ||
"""Tests updating proximity precision.""" | ||
index = empty_index() | ||
response = index.update_localized_attributes(NEW_LOCALIZED_ATTRIBUTES) | ||
update = index.wait_for_task(response.task_uid) | ||
assert update.status == "succeeded" | ||
response = index.get_localized_attributes() | ||
assert NEW_LOCALIZED_ATTRIBUTES == unpack_loc_attrs_response(response) | ||
|
||
|
||
def test_reset_localized_attributes(empty_index): | ||
"""Tests resetting the proximity precision to its default value.""" | ||
index = empty_index() | ||
# Update the settings first | ||
response = index.update_localized_attributes(NEW_LOCALIZED_ATTRIBUTES) | ||
update = index.wait_for_task(response.task_uid) | ||
assert update.status == "succeeded" | ||
# Check the settings have been correctly updated | ||
response = index.get_localized_attributes() | ||
assert NEW_LOCALIZED_ATTRIBUTES == unpack_loc_attrs_response(response) | ||
# Check the reset of the settings | ||
response = index.reset_localized_attributes() | ||
update = index.wait_for_task(response.task_uid) | ||
assert update.status == "succeeded" | ||
response = index.get_localized_attributes() | ||
assert response is None |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.