Fix code samples errors #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eskombro Could you rebase your branch pliiiiiiz? |
eskombro
added
the
skip-changelog
eskombro
force-pushed
the
fix_code_samples
branch
from
344a6b6 to
1ebb6c3
Compare
bidoubiwa
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 1.
distinct_attribute_guide_1-> Rename indexIndex is 'jackets', not 'movies'
https://docs.meilisearch.com/guides/advanced_guides/distinct.html#example
Fix 2.
settings_guide_synonyms_1-> Fill missing sampleWas missing at https://docs.meilisearch.com/guides/advanced_guides/settings.html#example
Fix 3.
faceted_search_update_settings_1-> Change order in paramsJust to keep documentation tidy, the list of parameters should have the same order in the different SDKs examples (using cURL as reference)
https://docs.meilisearch.com/guides/advanced_guides/settings.html#example-3