Skip to content

Add custom search section in Getting Started #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2020

Conversation

curquiza
Copy link
Member

@curquiza curquiza commented Oct 15, 2020

Some time ago, some users in the PHP and JS SDKs told us the custom search is not that easy to apprehend. An example + a link to the docs might be useful for python users too 🙂

@curquiza curquiza requested a review from eskombro October 15, 2020 16:40
@curquiza curquiza force-pushed the add-custom-search-section branch from cb9a9a7 to 2e2cbda Compare October 15, 2020 16:41
@curquiza curquiza force-pushed the add-custom-search-section branch from 34e2d4d to d3150ab Compare October 15, 2020 16:50
eskombro
eskombro previously approved these changes Oct 20, 2020
Copy link
Member

@eskombro eskombro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, little suggestion to clarify the text link to the documentation (optional of course)

Co-authored-by: Samuel Jimenez <[email protected]>
@curquiza curquiza merged commit 7b92cef into master Oct 20, 2020
@curquiza curquiza deleted the add-custom-search-section branch October 20, 2020 11:01
@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants